-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /ocs/ from end of acceptance tests baseUrl #30943
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30943 +/- ##
==========================================
Coverage 62.28% 62.28%
+ Complexity 18396 18233 -163
==========================================
Files 1141 1141
Lines 68154 68154
Branches 1232 1232
==========================================
Hits 42449 42449
Misses 25344 25344
Partials 361 361
Continue to review full report at Codecov.
|
aba1092
to
7bc5975
Compare
@@ -122,7 +125,7 @@ public function __construct( | |||
) { | |||
|
|||
// Initialize your context here | |||
$this->baseUrl = $baseUrl; | |||
$this->baseUrl = rtrim($baseUrl, '/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rtrim()
are here for the benefit of future users. If they pass in the baseURL
parameter with a /
on the end, then we will cope with that.
7bc5975
to
d3bf613
Compare
d3bf613
to
22ce7b2
Compare
Backport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 if CI passes
App acceptance test changes to work with this:
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
baseUrl
in the API acceptance tests to no longer have/ocs/
on the end of it.baseUrl
with an without a trailing slash.substr($this->baseUrl, 0, -5)
now use the method to getbaseUrl
baseUrl
from the APIFeatureContext
and does not keep trying to get it fromgetMinkParameter("base_url")
Related Issue
#30879
owncloud/QA#517
Motivation and Context
Bring API and UI acceptance tests even closer together. By using a common format for
baseUrl
it will be easier to make a common script for running any acceptance test.How Has This Been Tested?
Locally and CI
Types of changes
Checklist: